refactor(web): disable tile opacity controls when Google Map tiles are present[VIZ-DEV-71] - #167
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enforces Google Maps tile full-opacity behavior (for ToS compliance) by forcing tile opacity to 1 at render time and disabling the opacity control in the editor UI when Google tiles are involved.
Changes:
- Added i18n copy explaining why opacity controls are disabled when Google Maps tiles are present.
- Updated Visualizer scene-property transformation to override tile opacity for Google tile types.
- Propagated a
disabledflag throughPropertyItem → PropertyField → SliderFieldto disable the tile opacity slider in the editor.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/services/i18n/translations/ja.yml | Adds Japanese translation for the “opacity disabled for Google tiles” description. |
| web/src/services/i18n/translations/en.yml | Adds English translation for the “opacity disabled for Google tiles” description. |
| web/src/classic/components/molecules/Visualizer/hooks.ts | Forces tile opacity to 1 when Google tile types are present. |
| web/src/classic/components/molecules/EarthEditor/PropertyPane/PropertyItem/index.tsx | Disables the opacity field (and adds description) when Google tiles are detected. |
| web/src/classic/components/molecules/EarthEditor/PropertyPane/PropertyField/SliderField/index.tsx | Wires disabled into the RCSlider instance and adjusts disabled styling. |
| web/src/classic/components/molecules/EarthEditor/PropertyPane/PropertyField/index.tsx | Adds disabled prop plumbing down into field components. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
airslice
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enforces full opacity for Google Maps tiles to align with Google Maps Platform Terms of Service, which require map tiles to be displayed without transparency modifications. When a layer contains one or more Google Maps tile sources, the tile opacity is automatically set to 1, and the opacity control is disabled in the UI to prevent unsupported configuration changes and ensure consistent rendering behavior.
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo